Skip to content

add controller log override#956

Open
emmuhamm wants to merge 1 commit into
developfrom
emmuhamm/controller-log-override
Open

add controller log override#956
emmuhamm wants to merge 1 commit into
developfrom
emmuhamm/controller-log-override

Conversation

@emmuhamm

@emmuhamm emmuhamm commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fixes #885

Add a controller log override for the controllers.

boot -cl DEBUG or similar

Follow up

  • some of the outputs in the controller log are full of rich text which isnt the best
  • probalby shouldn't be fixed now since
    • fixes now would be hacky
    • better place to fix would be to instead use the file handlers to replace the log stdout redirects
    • Might also require better deciding of where the logs go and all that jazz

Type of change

  • New feature / enhancement

List of required branches from other repositories

N/A

Suggested manual testing checklist

boot -cl [log level] and see desired changes.

Developer checklist

Prior to marking this as "Ready for Review"

Tests ran on: WHAT HOSTNAME from release RELEASE_NAME

Unit tests - some tests can't be ran on the CI. This is documented. If this PR checks a feature that can't be tested with CI, this has been marked appropriately.

Integration tests - the daqsystemtest_integtest_bundle requires a lot of resources, and connections to the EHN1 infrastructure. Check the cross referenced list if you can't run these. The developer needs to run at least the .

  • Unit tests (pytest --marker) passed
    • With relevant marker
    • Without marker
  • Integration tests passed
    • Only daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.py
    • Full daqsystemtest_integtest_bundle.sh
  • Testing skipped as there are no core code changes in this PR, this only relates to documentation/CI workflows
  • Drunc integration tests pass (./scripts/drunc_integtest_bundle.sh)

Final checklist prior to marking this as "Ready for Review"

  • Code is clearly commented.
  • New unit tests have been added, or is documented in # ISSUE NUMBER
  • A suitable reviewer has been chosen from this list.

Reviewer checklist
  • This branch has been rebased with develop prior to testing.
  • Suggested manual tests show changes.
  • CI workflows fails documented (if present)
  • Integration tests passed (on either np0x or IC HEP clusters)
    • Use the following guidelines to determine which of the integration tests you need to run
      • You do not need to run any integration tests if
        • Code changes are not associated with src/
        • PR changes only affect docstrings
        • In this case, be sure to validate any suggested manual testing.
      • Run only the minimum integration test as daqsystemtest_integtest_bundle.sh -k minimal_system_quick_test.py if
        • PR changes only affect a few log entries
        • PR changes are small, and do not have a large impact on the workflow (use carefully)
      • Otherwise run the full integration test bundle as daqsystemtest_integtest_bundle.sh
    • What to do if the integration tests fail?
      • Only concern yourself if failures related to drunc are in the log files
      • If non-drunc failure appears:
        • Validate failure in fresh working area
        • Contact Pawel if unsure
  • If you have ran the full integration test bundle, leave a comment on the PR stating
    • Which host the integration tests have ran on
    • [Optional] A copy of the test summary
  • Drunc integration tests pass (scripts/drunc_integtest_bundle.sh)

Once the above boxes are checked, the PR(s) can be merged following the steps below.

Prior to merging

 Choose one of the following an complete all substeps
  • Changes only affect the Run Control, are in a single repository, and do not affect the end user.
    • Changes are documented in docstrings and code comments
    • Wiki has been updated if architectural or endpoint changes
  • Otherwise
    • Workflow changes demonstrated in the Change Log (if necessary)
    • Wiki has been updated (if necessary)
    • #dunedaq-integration Slack channel notified (see below)

Once completed, the reviewer can merge the PR.

Notification message for a Slack channel

Note - this should be to #dunedaq-integration for general workflow that isn't during a release candidate period, and to #daq-release-prep otherwise.

For an single merge that changes the user workflow

The CCM WG has an isolated PR ready to merge that affects user workflows. The PR is:

_URL_

I will leave time for any comments, otherwise will merge these at the end of the work day _Insert your time zone_.

For co-ordinated merge

The CCM WG has a set of co-ordinated merges ready to merge. The PRs are:

_URL_

_URL_


I will leave time for any comments, otherwise will merge these at the end of the day.

@emmuhamm emmuhamm self-assigned this Jun 23, 2026
@emmuhamm
emmuhamm force-pushed the emmuhamm/controller-log-override branch from ab32a94 to 0a4969e Compare June 23, 2026 13:44
@emmuhamm

emmuhamm commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

cc @PawelPlesniak

Controller log override
#956
code works, should be ready to go in
uncovered rich stuff in the controller logs..

@emmuhamm
emmuhamm requested a review from PawelPlesniak June 29, 2026 10:44
@emmuhamm

emmuhamm commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

cc @PawelPlesniak

Controller log override
#956
code works, should be ready to go in
uncovered rich stuff in the controller logs..

@PawelPlesniak

PawelPlesniak commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

I actually think this may be OK in logic, but will definitely require a refinement on how we set the log handler names in the various scopes. For the use of the file handlers, I think we should not implement this, as the daq_appllications are written in C++ and do not have log handlers. If we did implement this, we would have split logic for the two, which I do not think comes with any material benefit outside of using native python tools with a cleaner logic, but wouldn't come with a functional benefit.

@emmuhamm

emmuhamm commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

get this ready for review (metadata)

@emmuhamm
emmuhamm marked this pull request as ready for review July 13, 2026 14:10
@emmuhamm

emmuhamm commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

@PawelPlesniak this is now ready for review. We've agreed that the rich stuff in the logs when controllers in debug is beyond the scope that we should tackle later on. And this code also improves upon the base so it should go in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PawelPlesniak PawelPlesniak Awaiting requested review from PawelPlesniak

At least 1 approving review is required to merge this pull request.

Assignees

@emmuhamm emmuhamm

@PawelPlesniak PawelPlesniak

Labels

Controller Process Manager Utilities

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Controller logs dont propagate the set log level

3 participants

@emmuhamm @PawelPlesniak @dunedaqbot